Skip to content

fixed uninitialized variable #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
padelsbach merged 1 commit into from
Aug 5, 2025
Merged

fixed uninitialized variable #246

padelsbach merged 1 commit into from
Aug 5, 2025

Conversation

@sebastian-carpenter
Copy link
Contributor

@sebastian-carpenter sebastian-carpenter commented Aug 5, 2025

printAmt was not initialized to 0.

This never showed up before so I assume it is related to my configuration. printAmt is only uninitialized when there is no public or private key specified (hasPub, hasPriv). Which are set like this:

int hasPriv = (selection & OSSL_KEYMGMT_SELECT_PRIVATE_KEY) != 0;           
int hasPub = (selection & OSSL_KEYMGMT_SELECT_PUBLIC_KEY) != 0;

I found this while building with the configuration specified in the documentation (Section 3.3.1 - 3.3.3)

OpenSSL:

git clone https://github.com/openssl/openssl.git
cd openssl
./config no-fips -shared
make
sudo make install

wolfSSL:

./configure --enable-opensslcoexist --enable-cmac --enable-keygen --enable-sha --enable-des3 --enable-aesctr --enable-aesccm --enable-x963kdf --enable-compkey CPPFLAGS="-DHAVE_AES_ECB -DWOLFSSL_AES_DIRECT -DWC_RSA_NO_PADDING -DWOLFSSL_PUBLIC_MP -DHAVE_PUBLIC_FFDHE -DWOLFSSL_DH_EXTRA -DWOLFSSL_PSS_LONG_SALT -DWOLFSSL_PSS_SALT_LEN_DISCOVER -DRSA_MIN_SIZE=1024" --enable-certgen --enable-aeskeywrap --enable-enckeys --enable-base16 --with-eccminsz=192
make
sudo make install

wolfProvider:

./configure
make
make check

@sebastian-carpenter
fixed unititialized variable
23c2c1d 
printAmt was not initialized to 0
@sebastian-carpenter sebastian-carpenter self-assigned this Aug 5, 2025
@padelsbach
Copy link
Contributor

padelsbach commented Aug 5, 2025

Good catch, thanks for the PR. This fix is also captured in #234, but that PR will take a bit longer.

@padelsbach padelsbach merged commit 73aa5bf into wolfSSL:master Aug 5, 2025
282 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@padelsbach padelsbach padelsbach approved these changes

Assignees

@sebastian-carpenter sebastian-carpenter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebastian-carpenter @padelsbach